docs: finish v4 migration doc #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordOfPolls
reviewed
Mar 29, 2023
Co-authored-by: LordOfPolls <dev@lordofpolls.com>
LordOfPolls
approved these changes
Mar 30, 2023
Contributor
|
Not merging pending approval from a 4.x user |
Damego
reviewed
Mar 30, 2023
|
|
||
| These should be a lot more familiar to you - many interactions in v5 that aren't slash commands are similar to v4, minus name changes (largely to the decorators and classes you use). They should still *function* similarly though, but it's never a bad idea to consult the various guides that are on the sidebar to gain a better picture of how they work. | ||
|
|
||
| [If you're using context menus](../04 Context Menus) (IE `@bot.user_command` or `@bot.message_command`), note that the decorator you use is slightly different from either of the two older ones. You now use `@context_menu`, and specify the type of context menu through `context_type` - otherwise, it's mostly the same. |
Member
There was a problem hiding this comment.
We added equivalents message_context_menu and user_context_menu decorators. Can you add info there?
Contributor
Author
There was a problem hiding this comment.
Done, maybe I should add in the Context Menu guide the mention of these two decorators? (I just learned they exist lol)
Member
There was a problem hiding this comment.
Not in this pr I think, but better ask Polls about it
AlbertUnruh
approved these changes
Mar 30, 2023
Damego
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request attempts to finish the v4 Migration doc page.
Checklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.versionadded,versionchangedanddeprecatedto any new or changed user-facing function I committed.Pull-Request specification
I've made this pull request: (check all that apply)
This is: